Treat trait exclusively as Item not Type#744
Merged
sbillig merged 1 commit intoargotorg:masterfrom Jun 17, 2022
Merged
Conversation
cburgdorf
commented
Jun 17, 2022
| let named_thing = context.resolve_name(&base.kind, desc.span)?; | ||
| resolve_concrete_trait_named_thing(context, named_thing, desc) | ||
| } | ||
| _ => panic!("Should be rejected by parser"), |
Collaborator
Author
There was a problem hiding this comment.
Maybe we should use a special BoundDesc in the parser instead?
cburgdorf
force-pushed
the
christoph/feat/trait_as_item
branch
from
48d95e9 to
d067633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
This is a follow up to #710 which defined
Type::Trait. Traits are currently only supported as bounds on generics. Since for the foreseeable future we do not plan to support traits in places where types are supported we should remove it fromTypeand instead create anItem::Trait(TraitId)How was it fixed?
Pretty much what the description already spoiled.